xobs/lca2019-talk
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix callback calling when using from a parent directory

Browse Source 
Authors might want to use a shared reveal.js installation for all their
presentations such as:

	$ ls -1 -F
	20120105-how-to-use-git.html
	20121101-wikimedia-scaling.html
	reveal.js/
	$

In this case, the plugin callbacks will not be called at all.

When using head.js, the callback is marked as depending upon the loading of a
Javscript filename. The regex used to find out the filename is applied to the
full path which in the above case would be something like:

	reveal.js/plugin/highlight/highlight.js

The regex will thus give out 'reveal.js' as a file depency instead of the
expected 'highlight.js'

The fix is quiet easy: simply make sure that we are looking for a file that
actually ends with '.js' instead of simply containing '.js' by adding a $.
This commit is contained in:
Antoine Musso
2012-11-12 16:47:40 +01:00
parent 4c8938029d
commit 5354b78869
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/reveal.js
View File

@@ -232,7 +232,7 @@ var Reveal = (function(){
// Extension may contain callback functions // Extension may contain callback functions
if( typeof s.callback === 'function' ) { if( typeof s.callback === 'function' ) {
head.ready( s.src.match( /([\w\d_\-]*)\.?js|[^\\\/]*$/i )[0], s.callback ); head.ready( s.src.match( /([\w\d_\-]*)\.?js$|[^\\\/]*$/i )[0], s.callback );
} }
} }
} }