From 8c9c0ab0a64f32e8aa567009a82bac57464f4f93 Mon Sep 17 00:00:00 2001 From: Hakim El Hattab Date: Tue, 20 May 2014 08:14:48 +0200 Subject: [PATCH] validate named links according to html id spec #914 --- js/reveal.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/js/reveal.js b/js/reveal.js index a1d9caa..6097eea 100644 --- a/js/reveal.js +++ b/js/reveal.js @@ -2595,14 +2595,11 @@ if( isNaN( parseInt( bits[0], 10 ) ) && name.length ) { var element; - try { - // Find the slide with the specified name + // Ensure the named link is a valid HTML ID attribute + if( /^[a-zA-Z][\w:.-]*$/.test( name ) ) { + // Find the slide with the specified ID element = document.querySelector( '#' + name ); } - catch( e ) { - // If the ID is an invalid selector a harmless SyntaxError - // may be thrown here. - } if( element ) { // Find the position of the named slide and navigate to it